Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTR feature rename + docs #1496

Merged
merged 156 commits into from
Apr 4, 2021
Merged

LTR feature rename + docs #1496

merged 156 commits into from
Apr 4, 2021

Conversation

stephaniewhoo
Copy link
Member

  • feature description list
  • rename features for consistency

nsndimt and others added 30 commits September 26, 2020 11:30
@nsndimt
cmd interface draft
09bb05d
change pom.xml accordingly
a048212
@nsndimt
separate cli file
3cdff3d
@nsndimt
fix null pointer problem by remove static
c6ea60e
@nsndimt
remove more static
ac4a768
@nsndimt
add benchmark
5b49dcd
@nsndimt
add benchmark
127ce6f
@nsndimt
fix benchmark
8d0dcc7
@nsndimt
add idf caching to bm25
7d6c76a
@nsndimt
add idf caching to avgidf,tfidf
eab462b
@stephaniewhoo
Merge branch 'cmdline' of https://github.com/nsndimt/anserini into cm…
1f405e6 
…dline
@stephaniewhoo
add overall execution time and modified print format
8d42ac5
@stephaniewhoo
modify based on PR comments: indentation + list
84febdd
@stephaniewhoo
utils indentation + cli print debug msg format
c88cbbe
@nsndimt
ContentContext draft
c5e7167
@nsndimt
ContentContext draft
9fc26f5
@nsndimt
ContentContext QueryContext draft
88b47bc
@nsndimt
ContentContext QueryContext draft
d5ab11a
@nsndimt
ContentContext QueryContext draft
a42fb58
@nsndimt
rewrite count bigram
d2c509e
@nsndimt
rewrite count bigram
b90aa6e
@nsndimt
add pooler
cb9fcd8
@stephaniewhoo
rewrite features SCQ, SCS and TFIDF
fd2e913
@stephaniewhoo
Merge branch 'more_feature' of https://github.com/nsndimt/anserini in…
b472216 
…to more_feature

� Conflicts:
�	src/main/java/io/anserini/ltr/feature/ContentContext.java
@stephaniewhoo
add termFreq to ContentContext
d4f612e
@nsndimt
move on without some features that will not be used immediately
b50a64e
@nsndimt
discuss tfidf implementation later;
ca42a04 
discuss pl2 implementation later;
@nsndimt
refine name
f70c477
@nsndimt
fix feature name;
1e6f5d2 
fix zero divide;
@nsndimt
fix LMDir
8a9a922
stephaniewhoo and others added 14 commits March 15, 2021 21:56
@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #1496 (7b80bea) into master (f110d36) will decrease coverage by 0.29%.
The diff coverage is 54.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1496      +/-   ##
============================================
- Coverage     57.57%   57.27%   -0.30%     
  Complexity      978      978              
============================================
  Files           166      166              
  Lines          9007     9101      +94     
  Branches       1227     1231       +4     
============================================
+ Hits           5186     5213      +27     
- Misses         3431     3498      +67     
  Partials        390      390
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/anserini/ltr/AvgPooler.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...rc/main/java/io/anserini/ltr/ConfidencePooler.java 0.00% <ø> (ø) 0.00 <0.00> (?)
src/main/java/io/anserini/ltr/DocumentContext.java 55.17% <ø> (ø) 4.00 <0.00> (?)
...ain/java/io/anserini/ltr/DocumentFieldContext.java 42.06% <ø> (ø) 15.00 <0.00> (?)
...main/java/io/anserini/ltr/FeatureExtractorCli.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/io/anserini/ltr/FeatureExtractorUtils.java 66.26% <ø> (ø) 23.00 <0.00> (ø)
...c/main/java/io/anserini/ltr/MaxMinRatioPooler.java 0.00% <ø> (ø) 0.00 <0.00> (?)
src/main/java/io/anserini/ltr/MaxPooler.java 0.00% <ø> (ø) 0.00 <0.00> (?)
src/main/java/io/anserini/ltr/MedianPooler.java 0.00% <ø> (ø) 0.00 <0.00> (?)
src/main/java/io/anserini/ltr/MinPooler.java 0.00% <ø> (ø) 0.00 <0.00> (?)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f110d36...7b80bea. Read the comment docs.

@stephaniewhoo stephaniewhoo mentioned this pull request Mar 31, 2021
Closed
lintool
lintool requested changes Apr 2, 2021
View reviewed changes
Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really torn now... DFR_GL2Stat -> DFRGL2Stat looks terrible.

I think I would even prefer DrfGl2Stat? For example, TfIdfStat looks fine to me...

Thoughts? Even Huggingface does BertTokenizer... which is kinda ugly but consistent...

docs/ltr-features.md Outdated Show resolved Hide resolved
src/main/java/io/anserini/ltr/feature/BM25Stat.java Outdated Show resolved Hide resolved
@lintool lintool merged commit a2cfe15 into castorini:master Apr 4, 2021
@lintool lintool mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lintool lintool lintool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephaniewhoo @lintool @nsndimt @yuki617