Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring TopicReader, exposing background link topics from TREC 2020 News Track #1502

Merged
merged 2 commits into from
Apr 4, 2021

Conversation

lintool
Copy link
Member

@lintool lintool commented Apr 2, 2021

Better way of building TOPIC_FILE_TO_TYPE mapping so we don't have to enter same information twice.

@lintool lintool requested a review from MXueguang April 2, 2021 12:12
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1502 (f6a2f16) into master (346cb9b) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1502      +/-   ##
============================================
- Coverage     57.79%   57.57%   -0.22%     
- Complexity      977      978       +1     
============================================
  Files           166      166              
  Lines          9053     9007      -46     
  Branches       1226     1227       +1     
============================================
- Hits           5232     5186      -46     
  Misses         3431     3431              
  Partials        390      390              
Impacted Files Coverage Δ Complexity Δ
...va/io/anserini/search/topicreader/TopicReader.java 63.46% <100.00%> (-17.35%) 12.00 <2.00> (+1.00) ⬇️
...in/java/io/anserini/search/topicreader/Topics.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346cb9b...f6a2f16. Read the comment docs.

@lintool lintool merged commit f110d36 into master Apr 4, 2021
@lintool lintool deleted the bg-topics branch April 4, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants