Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved e2e testing: implemented getDocumentTokens in IndexReaderUtils #1521

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

lintool
Copy link
Member

@lintool lintool commented Apr 15, 2021

Implemented getDocumentTokens, which returns a list of tokens - this makes testing easier than getDocumentVector.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #1521 (f8d1932) into master (6b24bbd) will increase coverage by 0.04%.
The diff coverage is 72.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1521      +/-   ##
============================================
+ Coverage     57.38%   57.43%   +0.04%     
- Complexity      982      988       +6     
============================================
  Files           166      166              
  Lines          9107     9136      +29     
  Branches       1231     1240       +9     
============================================
+ Hits           5226     5247      +21     
- Misses         3494     3498       +4     
- Partials        387      391       +4     
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/anserini/index/IndexReaderUtils.java 76.79% <72.41%> (-0.62%) 44.00 <6.00> (+6.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b24bbd...f8d1932. Read the comment docs.

Copy link
Member

@stephaniewhoo stephaniewhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this makes doc tokens clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants