Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build warnings #1710

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Cleanup build warnings #1710

merged 1 commit into from
Dec 18, 2021

Conversation

lintool
Copy link
Member

@lintool lintool commented Dec 18, 2021

hey @stephaniewhoo can you take a look? some of this is your code, I think.

Map<String, Object> json = new HashMap();

Just suppressing may not be the cleanest collection... is there a more appropriate specialized type than Object?


Otherwise, fixed a bunch of minor build warnings.

@codecov-commenter
Copy link

Codecov Report

Merging #1710 (dea9498) into master (349db4c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1710   +/-   ##
=========================================
  Coverage     57.58%   57.58%           
  Complexity     1032     1032           
=========================================
  Files           173      173           
  Lines          9781     9781           
  Branches       1344     1344           
=========================================
  Hits           5632     5632           
  Misses         3675     3675           
  Partials        474      474           
Impacted Files Coverage Δ
.../anserini/collection/CommonCrawlWetCollection.java 74.35% <ø> (ø)
...ava/io/anserini/collection/DocumentCollection.java 57.33% <ø> (ø)
...o/anserini/collection/FeverSentenceCollection.java 83.63% <ø> (ø)
.../java/io/anserini/collection/WarcBaseDocument.java 42.68% <ø> (ø)
...in/java/io/anserini/ltr/FeatureExtractorUtils.java 66.26% <ø> (ø)
...c/main/java/io/anserini/ltr/QueryFieldContext.java 59.37% <ø> (ø)
...anserini/search/SimpleNearestNeighborSearcher.java 89.74% <ø> (ø)
...arch/topicreader/BackgroundLinkingTopicReader.java 29.76% <ø> (ø)
...in/java/io/anserini/search/topicreader/Topics.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349db4c...dea9498. Read the comment docs.

@stephaniewhoo
Copy link
Member

The Object may be String or List<String>, so I am afraid that it cannot be further specified.

@lintool
Copy link
Member Author

lintool commented Dec 18, 2021

Okay, in that case can you do a CR and give me a 🚢 it of it looks good?

Copy link
Member

@stephaniewhoo stephaniewhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lintool lintool merged commit c0fa772 into master Dec 18, 2021
@lintool lintool deleted the cleanup branch December 18, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants