-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pyserini bindings to Lucene 9 #1961
Conversation
we change the name style to python style in SimpleSearchers? |
Yes... since this is a major breaking upgrade, I thought I'd do some cleanup while I was at it. This would bring closer alignment to the pyserini end. Thoughts? Let me know if you don't think this is a good idea? |
I think its good, simple(impact)searchers are for python anyway |
Codecov Report
@@ Coverage Diff @@
## master #1961 +/- ##
============================================
+ Coverage 60.14% 60.21% +0.07%
- Complexity 1061 1065 +4
============================================
Files 178 178
Lines 9903 9811 -92
Branches 1371 1359 -12
============================================
- Hits 5956 5908 -48
+ Misses 3441 3429 -12
+ Partials 506 474 -32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Exposes Lucene 8 backwards compatibility bindings in
SimpleSearcher
andSimpleImpactSearcher
.Basically, if we detect Lucene 8 indexes, we disable consistent tie-breaking, which depends on docvalues; see #1952
Additional changes: