Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pyserini bindings to Lucene 9 #1961

Merged
merged 10 commits into from
Aug 17, 2022
Merged

Update Pyserini bindings to Lucene 9 #1961

merged 10 commits into from
Aug 17, 2022

Conversation

lintool
Copy link
Member

@lintool lintool commented Aug 16, 2022

Exposes Lucene 8 backwards compatibility bindings in SimpleSearcher and SimpleImpactSearcher.

Basically, if we detect Lucene 8 indexes, we disable consistent tie-breaking, which depends on docvalues; see #1952

Additional changes:

  • general cleanup (fixed code formatting in SimpleImpactSearcher)
  • killed main in SimpleSearcher
  • Changed to Python method names (snake_case)

@lintool lintool marked this pull request as draft August 16, 2022 20:37
@lintool lintool changed the title Update Pyserini bindings to Lucene 9 [WIP] Update Pyserini bindings to Lucene 9 Aug 16, 2022
@MXueguang
Copy link
Member

we change the name style to python style in SimpleSearchers?

@lintool
Copy link
Member Author

lintool commented Aug 16, 2022

we change the name style to python style in SimpleSearchers?

Yes... since this is a major breaking upgrade, I thought I'd do some cleanup while I was at it. This would bring closer alignment to the pyserini end.

Thoughts? Let me know if you don't think this is a good idea?

@MXueguang
Copy link
Member

I think its good, simple(impact)searchers are for python anyway

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #1961 (4c98759) into master (0fc578a) will increase coverage by 0.07%.
The diff coverage is 76.37%.

❗ Current head 4c98759 differs from pull request most recent head 6a867f3. Consider uploading reports for the commit 6a867f3 to get more accurate results

@@             Coverage Diff              @@
##             master    #1961      +/-   ##
============================================
+ Coverage     60.14%   60.21%   +0.07%     
- Complexity     1061     1065       +4     
============================================
  Files           178      178              
  Lines          9903     9811      -92     
  Branches       1371     1359      -12     
============================================
- Hits           5956     5908      -48     
+ Misses         3441     3429      -12     
+ Partials        506      474      -32     
Impacted Files Coverage Δ
...rc/main/java/io/anserini/search/SearchMsmarco.java 0.00% <0.00%> (ø)
...n/java/io/anserini/search/SimpleTweetSearcher.java 0.00% <0.00%> (ø)
.../java/io/anserini/search/SimpleImpactSearcher.java 77.08% <76.34%> (+5.08%) ⬆️
...c/main/java/io/anserini/search/SimpleSearcher.java 65.65% <92.85%> (+2.13%) ⬆️
...anserini/rerank/lib/ScoreTiesAdjusterReranker.java 83.33% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lintool lintool marked this pull request as ready for review August 17, 2022 13:20
@lintool lintool changed the title [WIP] Update Pyserini bindings to Lucene 9 Update Pyserini bindings to Lucene 9 Aug 17, 2022
@lintool lintool merged commit e475cc4 into master Aug 17, 2022
@lintool lintool deleted the pyserini-lucene9 branch August 17, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants