Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General refactoring #2269

Merged
merged 6 commits into from
Nov 25, 2023
Merged

General refactoring #2269

merged 6 commits into from
Nov 25, 2023

Conversation

lintool
Copy link
Member

@lintool lintool commented Nov 23, 2023

  • Refactored SearchHnswDenseVectors and SearchInvertedDenseVectors, cleaning up code paths and main error handling.
  • Added test cases, cleaned up existing test cases.
  • Other minor cleanup

@lintool lintool marked this pull request as draft November 23, 2023 20:19
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (95a546c) 62.92% compared to head (0519a94) 63.40%.

Files Patch % Lines
...io/anserini/search/SearchInvertedDenseVectors.java 95.12% 0 Missing and 2 partials ⚠️
...ava/io/anserini/search/SearchHnswDenseVectors.java 97.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2269      +/-   ##
============================================
+ Coverage     62.92%   63.40%   +0.47%     
- Complexity     1271     1286      +15     
============================================
  Files           196      196              
  Lines         11423    11463      +40     
  Branches       1453     1457       +4     
============================================
+ Hits           7188     7268      +80     
+ Misses         3712     3672      -40     
  Partials        523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool marked this pull request as ready for review November 25, 2023 14:48
Copy link
Member

@ArthurChen189 ArthurChen189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lintool lintool merged commit 3435e8a into master Nov 25, 2023
3 checks passed
@lintool lintool deleted the refactoring branch November 25, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants