Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce e2e sparse+dense Lucene #2317

Merged
merged 5 commits into from
Dec 29, 2023

Conversation

ArthurChen189
Copy link
Member

Link to #2307

Usage:
python src/main/python/e2e_sparse_dense_lucene/reproduction.py

@ArthurChen189 ArthurChen189 marked this pull request as draft December 25, 2023 19:24
@ArthurChen189
Copy link
Member Author

Resolving result inconsistencies

TODO:

  • Update cos-dpr-distil index info

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (95e6abf) 64.44% compared to head (3f81b3e) 66.36%.
Report is 7 commits behind head on master.

Files Patch % Lines
...ain/java/io/anserini/search/HnswDenseSearcher.java 50.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2317      +/-   ##
============================================
+ Coverage     64.44%   66.36%   +1.92%     
- Complexity     1353     1397      +44     
============================================
  Files           205      205              
  Lines         11460    11439      -21     
  Branches       1442     1444       +2     
============================================
+ Hits           7385     7592     +207     
+ Misses         3583     3338     -245     
- Partials        492      509      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArthurChen189 ArthurChen189 marked this pull request as ready for review December 28, 2023 22:34
Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll come back and iterate, but this is a good start for now, okay to merge.

@ArthurChen189 ArthurChen189 merged commit 1ebe6dd into castorini:master Dec 29, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants