Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tolerance settings for MS MARCO dense vector regressions #2541

Merged
merged 8 commits into from
Jul 8, 2024

Conversation

lintool
Copy link
Member

@lintool lintool commented Jun 29, 2024

Continuation of #2538

  • tweak docs for flat indexes.
  • refactor tolerance values for HNSW indexes, calibrate wrt flat index scores.

@lintool lintool marked this pull request as draft June 29, 2024 11:18
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (9cc2d89) to head (ac56d2c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2541   +/-   ##
=========================================
  Coverage     67.07%   67.07%           
  Complexity     1481     1481           
=========================================
  Files           219      219           
  Lines         12670    12670           
  Branches       1530     1530           
=========================================
  Hits           8499     8499           
  Misses         3644     3644           
  Partials        527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool marked this pull request as ready for review July 7, 2024 19:40
@lintool
Copy link
Member Author

lintool commented Jul 7, 2024

@MXueguang @tteofili I've verified all results, we should be good to go.

@lintool lintool merged commit 3885b5c into master Jul 8, 2024
3 checks passed
@lintool lintool deleted the tolerance-refactoring branch July 8, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants