Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated guide for MS MARCO doc retrieval #949

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

lintool
Copy link
Member

@lintool lintool commented Jan 14, 2020

@edwinzhng wasn't able to replicate, and I confirmed that the documentation is incorrect.

@edwinzhng can you match your numbers with these? give me a +1 if they match - thanks!

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #949 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #949      +/-   ##
============================================
- Coverage     39.55%   39.48%   -0.07%     
+ Complexity      515      511       -4     
============================================
  Files           120      120              
  Lines          7231     7231              
  Branches       1086     1086              
============================================
- Hits           2860     2855       -5     
- Misses         4083     4088       +5     
  Partials        288      288
Impacted Files Coverage Δ Complexity Δ
...java/io/anserini/ltr/feature/CountBigramPairs.java 83.11% <0%> (-6.5%) 29% <0%> (-4%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568b74c...818f9ae. Read the comment docs.

Copy link
Member

@edwinzhng edwinzhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 was able to replicate the same values

@lintool lintool merged commit 3964169 into master Jan 14, 2020
@lintool lintool deleted the ms-macro-doc-fix branch January 14, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants