Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication log for Elastirini MS MARCO #956

Merged
merged 2 commits into from
Jan 19, 2020
Merged

Replication log for Elastirini MS MARCO #956

merged 2 commits into from
Jan 19, 2020

Conversation

edwinzhng
Copy link
Member

Title

@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@65dd1b0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #956   +/-   ##
=========================================
  Coverage          ?   39.57%           
  Complexity        ?      515           
=========================================
  Files             ?      120           
  Lines             ?     7249           
  Branches          ?     1087           
=========================================
  Hits              ?     2869           
  Misses            ?     4091           
  Partials          ?      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65dd1b0...a5ee572. Read the comment docs.

@lintool
Copy link
Member

lintool commented Jan 18, 2020

I would prefer a single heading "Replication Log"

And write "Results replicated ... MS MARCO Passage"

@edwinzhng
Copy link
Member Author

I would prefer a single heading "Replication Log"

And write "Results replicated ... MS MARCO Passage"

updated

@lintool
Copy link
Member

lintool commented Jan 19, 2020

Sorry to be pedantic, but Replication Logs -> Log (singular)
I'll +1 it now, merge yourself when you've tweaked please.

@edwinzhng
Copy link
Member Author

Sorry to be pedantic, but Replication Logs -> Log (singular)
I'll +1 it now, merge yourself when you've tweaked please.

Can't merge, I don't have write access

@lintool lintool merged commit 7e8ebae into castorini:master Jan 19, 2020
@edwinzhng edwinzhng deleted the elastirini-replication branch January 19, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants