Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsMarcoPassageLtrSearcher #611

Closed
lintool opened this issue May 23, 2021 · 1 comment
Closed

MsMarcoPassageLtrSearcher #611

lintool opened this issue May 23, 2021 · 1 comment
Assignees
@stephaniewhoo

Comments

@lintool
Copy link
Member

lintool commented May 23, 2021

Hi @stephaniewhoo - what do you think about refactoring your LTR code into something like MsMarcoPassageLtrSearcher alongside SimpleSearcher? https://github.com/castorini/pyserini/blob/master/pyserini/search/_searcher.py#L39

Currently we can do this:

$ python -m pyserini.search --topics msmarco-passage-dev-subset --index msmarco-passage --output run.msmarco-passage.txt --bm25 --output-format msmarco

We can similarly expose MsMarcoPassageLtrSearcher, something like:

$ python -m pyserini.msmarco_passage_ltr_search ... --model ...
@stephaniewhoo stephaniewhoo reopened this Jul 19, 2021
@stephaniewhoo
Copy link
Member

Close with #636

@stephaniewhoo stephaniewhoo mentioned this issue Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephaniewhoo stephaniewhoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lintool @stephaniewhoo