LTR refactoring for modularization #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephaniewhoo
commented
Jun 2, 2021
stephaniewhoo
commented
- LTR msmarco passage searcher modularization
- split training and reranking doc
lintool
reviewed
Jun 2, 2021
There was a problem hiding this comment.
hey @stephaniewhoo re:
pyserini/ltr/init.py → .../msmarco_passage_ltr_searcher/init.py
I like having the pyserini.ltr package as is.
I think my idea, per #611, was implementing something called MsMarcoPassageLtrSearcher in pyserini.search that packages up just the reranking feature. Most of the "core" LTR stuff can remain in pyersini.ltr.
What do you think?
|
updated PR as discussed in slack |
lintool
approved these changes
Jun 3, 2021
This was referenced Jul 19, 2021
MXueguang
pushed a commit
to MXueguang/pyserini
that referenced
this pull request
Nov 5, 2021
Modularization LTR reranking and split ltr doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.