Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative feedback option to Rocchio #1218

Merged
merged 21 commits into from
Jun 22, 2022
Merged

Conversation

yuki617
Copy link
Member

@yuki617 yuki617 commented Jun 22, 2022

  • Add negative label to Rocchio reranker
  • Add tests for Rocchio with negative feedback

@yuki617 yuki617 requested a review from lintool June 22, 2022 21:11
Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments? Thoughts?

pyserini/search/lucene/__main__.py Outdated Show resolved Hide resolved
pyserini/search/lucene/__main__.py Outdated Show resolved Hide resolved
@yuki617 yuki617 merged commit 6914743 into castorini:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants