-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTR document exp + regression test #844
Merged
stephaniewhoo
merged 17 commits into
castorini:master
from
stephaniewhoo:doc_refactoring
Oct 31, 2021
Merged
LTR document exp + regression test #844
stephaniewhoo
merged 17 commits into
castorini:master
from
stephaniewhoo:doc_refactoring
Oct 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephaniewhoo
commented
Oct 29, 2021
- refactoring LTR to support document exp
- add regression test for document
- add documents for LTR document repro
lintool
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, based on a quick glance.
@yuki617 please take a closer look, and then we can meger.
yuki617
approved these changes
Oct 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
MXueguang
pushed a commit
to MXueguang/pyserini
that referenced
this pull request
Nov 5, 2021
+ LTR document exp + LTR doc repro documentation + LTR document regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.