-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ferc1 output assets #2856
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rename-core-assets #2856 +/- ##
==================================================
Coverage 88.5% 88.5%
==================================================
Files 90 90
Lines 10139 10139
==================================================
Hits 8982 8982
Misses 1157 1157
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The renames look good, but I can't get this to work with the current migration - you'll likely have to rebase your migration on mine?
I just recreated the migration. Let me know if it works for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Was able to run the assets and validation tests without issue.
PR Overview
Apply new naming conventions to the ferc1 output assets/tables.
There are 5 assets that should not be user-facing so I added a preceding underscore to them. However, they still use the
pudl_sqlite_io_manager
becausePudlTabl
methods pull these tables from the database. When we deprecatePudlTabl
, we can use the default io manager for these tables.This can be merged into once all of the core assets have been renamed and the ci tests are passing on
rename-core-assets
.PR Checklist
dev
).