Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ferc1 output assets #2856

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Conversation

bendnorman
Copy link
Member

PR Overview

Apply new naming conventions to the ferc1 output assets/tables.

There are 5 assets that should not be user-facing so I added a preceding underscore to them. However, they still use the pudl_sqlite_io_manager because PudlTabl methods pull these tables from the database. When we deprecate PudlTabl, we can use the default io manager for these tables.

This can be merged into once all of the core assets have been renamed and the ci tests are passing on rename-core-assets.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@bendnorman bendnorman requested a review from e-belfer September 13, 2023 21:27
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (ec426d6) 88.5% compared to head (00ce1e9) 88.5%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           rename-core-assets   #2856   +/-   ##
==================================================
  Coverage                88.5%   88.5%           
==================================================
  Files                      90      90           
  Lines                   10139   10139           
==================================================
  Hits                     8982    8982           
  Misses                   1157    1157           
Files Changed Coverage Δ
src/pudl/metadata/resources/ferc1.py 100.0% <ø> (ø)
src/pudl/output/pudltabl.py 90.1% <ø> (ø)
src/pudl/output/ferc1.py 99.2% <100.0%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renames look good, but I can't get this to work with the current migration - you'll likely have to rebase your migration on mine?

@bendnorman
Copy link
Member Author

I just recreated the migration. Let me know if it works for you.

@e-belfer e-belfer self-requested a review September 18, 2023 14:41
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Was able to run the assets and validation tests without issue.

@bendnorman bendnorman merged commit 0a912e4 into rename-core-assets Sep 18, 2023
@bendnorman bendnorman deleted the rename-ferc-output-assets branch September 18, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants