Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflicting dependencies #2900

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Resolve conflicting dependencies #2900

merged 4 commits into from
Sep 28, 2023

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Sep 27, 2023

PR Overview

Mostly this PR narrows the allowed versions specified in pyproject.toml which allows the environment to be solved by pip and also seems to speed up environment creation a bit. However, I'm still totally ignorant of what the underlying problem was.

  • Bump the version of sphinx-autoapi and remove the no longer required astroid pin.
  • Add specific version pins for grcpio packages, since pip was spinning its wheels looking for something compatible.
  • Require a recent version of boto3 so pip doesn't look back through every possible past version.
  • Narrow the allowed versions of many packages to the most recent major version.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@zaneselvans zaneselvans marked this pull request as draft September 27, 2023 16:52
@zaneselvans zaneselvans marked this pull request as ready for review September 27, 2023 20:25
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9615220) 88.6% compared to head (929d4ab) 88.6%.
Report is 32 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2900   +/-   ##
=====================================
  Coverage   88.6%   88.6%           
=====================================
  Files         90      90           
  Lines      10808   10808           
=====================================
  Hits        9576    9576           
  Misses      1232    1232           
Files Coverage Δ
src/pudl/output/ferc1.py 88.7% <100.0%> (ø)
src/pudl/transform/ferc1.py 96.6% <100.0%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaneselvans zaneselvans added the dependencies Pull requests that update a dependency file label Sep 27, 2023
@zaneselvans zaneselvans changed the title Use sphinx-autoapi 3.0 to work with astroid 3.0 Resolve conflicting dependencies; draft conda-lock setup Sep 27, 2023
@zaneselvans zaneselvans linked an issue Sep 27, 2023 that may be closed by this pull request
@zaneselvans zaneselvans merged commit 0d3ec20 into dev Sep 28, 2023
5 checks passed
@zaneselvans zaneselvans deleted the sphinx-autoapi-3.0 branch September 28, 2023 01:23
@zaneselvans zaneselvans changed the title Resolve conflicting dependencies; draft conda-lock setup Resolve conflicting dependencies Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant