Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch regex strategy to sampling strategy to improve performance #2998

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

jdangerx
Copy link
Member

@jdangerx jdangerx commented Nov 1, 2023

See this failure, which is due to slow strategies: #2968 (comment)

We already know that pandera strategy generation is slow - combining that with the slowness of generating strings based on regex was too much I think.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (548b958) 88.6% compared to head (e5138a6) 88.6%.
Report is 62 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #2998    +/-   ##
======================================
  Coverage   88.6%   88.6%            
======================================
  Files         91      91            
  Lines      10854   10991   +137     
======================================
+ Hits        9618    9749   +131     
- Misses      1236    1242     +6     
Files Coverage Δ
src/pudl/transform/params/ferc1.py 100.0% <ø> (ø)
src/pudl/output/ferc1.py 88.2% <69.2%> (-0.5%) ⬇️
src/pudl/transform/ferc1.py 96.7% <94.8%> (+<0.1%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdangerx jdangerx requested a review from zaneselvans November 2, 2023 12:25
@jdangerx jdangerx merged commit c11b1a4 into dev Nov 2, 2023
9 checks passed
@jdangerx jdangerx linked an issue Nov 2, 2023 that may be closed by this pull request
@zaneselvans zaneselvans deleted the ferc-dedupe-test-performance branch November 2, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

test_filter_for_freshest_data occasionally fails
2 participants