Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dagster postgres env vars to build-deploy-pudl.yaml #3014

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

bendnorman
Copy link
Member

PR Overview

This PR adds the build-deploy-pudl.yaml workflow from #2996 to main so scheduled dev builds use the updated file.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbd82ba) 88.6% compared to head (c831080) 88.6%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3014   +/-   ##
=====================================
  Coverage   88.6%   88.6%           
=====================================
  Files         91      91           
  Lines      10991   10991           
=====================================
  Hits        9749    9749           
  Misses      1242    1242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏼

@bendnorman bendnorman merged commit ce1b983 into main Nov 4, 2023
9 checks passed
@bendnorman bendnorman deleted the add-dagster-postgres-env-vars branch November 4, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants