-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete Docker data access instructions. #3156
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #3156 +/- ##
=====================================
Coverage 92.7% 92.7%
=====================================
Files 134 134
Lines 12597 12598 +1
=====================================
+ Hits 11672 11676 +4
+ Misses 925 922 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to be honest, at a high level I greatly dislike that this whole How do I access the data?
does not just include a bunch of links to the data access page. Bc these two sets of access modes often diverge and end up having conflicting information. Could we just convert this whole section to be a link the the data access docs page and a list of the links to the headers on that page? Which is perhaps out of scope for this pr.
my one probably should be in scope for this pr request is that we at least add kaggle into the data access page. which could literally be a copy paste of this language.
`the Catalyst Cooperative Community <https://zenodo.org/communities/catalyst-cooperative/>`__. | ||
Zenodo assigns long-lived DOIs to each archive, suitable for citation in academic | ||
journals and other publications. The most recent versioned PUDL data release can be | ||
found using this Concept DOI: https://doi.org/10.5281/zenodo.3653158 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1000% nit but using the "Concept DOI" language is jargony and imo not adding anything.
Overview
How did you make sure this worked? How can a reviewer verify this?
To-do list