Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up nightly build/deploy w/o nightly branch update. #3188

Merged
merged 23 commits into from
Dec 22, 2023
Merged

Clean up nightly build/deploy w/o nightly branch update. #3188

merged 23 commits into from
Dec 22, 2023

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Dec 22, 2023 •
edited
Loading

Takes the working elements of #3183 and gets them merged into main so the builds are working again.

  • Fix syntax error in build-deploy-pudl workflow.
  • Move envvar printing into separate step
  • Rename GITHUB_REF to BUILD_REF
  • set the nightly tag, so we have something to merge
  • Allow write permissions for git tagging in nightly builds workflow
  • Functionalize udpate_nightly_branch()
  • Set origin for nightly when pushing.
  • Temporarily disable nightly branch updates to fix nightly builds.

zaneselvans and others added 23 commits December 21, 2023 08:39
@zaneselvans
Fix syntax error in build-deploy-pudl workflow.
a97fe00
@zaneselvans
Move envvar printing into separate step
d6ff8e6
@zaneselvans
Rename GITHUB_REF to BUILD_REF
bc2df9c
@zaneselvans
Force full nightly deployment on workflow_dispatch for testing
876eb3e
@zaneselvans
Disable all the hard work and just update tags/branch
92ad79f
@zaneselvans
set the nightly tag, so we have something to merge
b7bfa31
@zaneselvans
Allow write permissions for git tagging in nightly builds workflow
92667d7
@zaneselvans
Try checking out origin/nightly before merging.
1e77a95
@zaneselvans
Simplify short-circuit testing for git stuff
1749f8f
@zaneselvans
Don't shut down VM
b65a8bf
@zaneselvans
Checkout the whole repo
a23686f
@zaneselvans
Update container git checkout
150c181
@zaneselvans
whatever
4dc9472
@zaneselvans
Functionalize udpate_nightly_branch()
a254f9e
@zaneselvans
Telltale heart
bb6164d
@zaneselvans
watermark
3684c56
@jdangerx
Try logging out the actual docker image digest being run on VM
7adbbf3
@zaneselvans @jdangerx
Update docker/gcp_pudl_etl.sh
b038378 
Co-authored-by: Dazhong Xia <dazhong.xia@catalyst.coop>
@zaneselvans
Revert to shallow checkout of the repo in build-deploy-pudl action
e42a3ac
@jdangerx
Revert "Try logging out the actual docker image digest being run on VM"
7c0d8b7 
This reverts commit 7adbbf3.
@jdangerx
no-op echo change to see if that dodges VM startup failures.
df98c90
@jdangerx
Set origin for nightly when pushing.
4d7801e
@zaneselvans
Temporarily disable nightly branch updates to fix nightly builds.
f746a24
@zaneselvans zaneselvans requested a review from jdangerx December 22, 2023 18:24
@zaneselvans zaneselvans added the nightly-builds Anything having to do with nightly builds or continuous deployment. label Dec 22, 2023
@zaneselvans zaneselvans self-assigned this Dec 22, 2023
@zaneselvans zaneselvans enabled auto-merge (squash) December 22, 2023 18:50
@zaneselvans zaneselvans disabled auto-merge December 22, 2023 19:56
@zaneselvans zaneselvans merged commit 7685a02 into main Dec 22, 2023
12 of 13 checks passed
@zaneselvans zaneselvans deleted the hotfix-nightly-builds branch December 22, 2023 19:57
@zaneselvans
Copy link
Member Author

The ci-integration runner got killed when attempting to cache an epacems archive. I've seen this happen occasionally elsewhere too, but it doesn't seem to be consistent/repeatable. I went ahead and overrode it to merge, but I'm a little worried that with the new annual epacems archives we may see this problem more frequently. @e-belfer

@zaneselvans zaneselvans mentioned this pull request Dec 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdangerx jdangerx jdangerx approved these changes

Assignees

@zaneselvans zaneselvans

Labels
nightly-builds Anything having to do with nightly builds or continuous deployment.
Projects
Catalyst Megaproject
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaneselvans @jdangerx