Move pudl_etl_job_factory
back to pudl.etl.cli.py
#3711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3708.
What problem does this address?
#3687 broke the
pudl_etl
command becausebuild_reconstructable_job
needspudl_etl_job_factory
to be in the same file:pudl/src/pudl/etl/cli.py
Lines 131 to 139 in c153929
What did you change?
This PR just reverts the
pudl_etl_job_factory
move that happened in #3687.I also fleshed out this issue which would allow us to migrate away from the experimental and confusing
build_reconstructable_job
method.Testing
How did you make sure this worked? How can a reviewer verify this?
make pytest-coverage
andpudl_etl
and they both started without the error.To-do list