Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pudl_etl_job_factory back to pudl.etl.cli.py #3711

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

bendnorman
Copy link
Member

@bendnorman bendnorman commented Jul 3, 2024

Overview

Closes #3708.

What problem does this address?
#3687 broke the pudl_etl command because build_reconstructable_job needs pudl_etl_job_factory to be in the same file:

pudl/src/pudl/etl/cli.py

Lines 131 to 139 in c153929

pudl_etl_reconstructable_job = build_reconstructable_job(
"pudl.etl.cli",
"pudl_etl_job_factory",
reconstructable_kwargs={
"loglevel": loglevel,
"logfile": logfile,
"process_epacems": process_epacems,
},
)

What did you change?
This PR just reverts the pudl_etl_job_factory move that happened in #3687.

I also fleshed out this issue which would allow us to migrate away from the experimental and confusing build_reconstructable_job method.

Testing

How did you make sure this worked? How can a reviewer verify this?

  • I ran make pytest-coverage and pudl_etl and they both started without the error.

To-do list

Preview Give feedback

@bendnorman bendnorman requested a review from zaneselvans July 3, 2024 22:21
@bendnorman bendnorman self-assigned this Jul 3, 2024
@bendnorman bendnorman added dagster Issues related to our use of the Dagster orchestrator nightly-builds Anything having to do with nightly builds or continuous deployment. labels Jul 3, 2024
@bendnorman bendnorman added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit f977c74 Jul 4, 2024
12 checks passed
@bendnorman bendnorman deleted the patch-3708 branch July 4, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dagster Issues related to our use of the Dagster orchestrator nightly-builds Anything having to do with nightly builds or continuous deployment.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Nightly Build Failure 2024-07-03
2 participants