-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libp2p in catalyst #1245
Merged
Merged
Use libp2p in catalyst #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhirtibrewal
previously approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok. need through testing
src/Catalyst.Abstractions/P2P/Protocols/IPeerChallengeResponse.cs
Outdated
Show resolved
Hide resolved
src/Catalyst.Abstractions/P2P/Protocols/IPeerQueryTipResponse.cs
Outdated
Show resolved
Hide resolved
src/Catalyst.Abstractions/Sync/Interfaces/IDeltaHeightWatcher.cs
Outdated
Show resolved
Hide resolved
franssl
previously approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Submissions:
closes #1
) ?What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix,
Feature
What is the current behavior?
Nodes use PeerId's while LibP2P uses MultiAddress's, because we are integrating LibP2P within Catalyst there is no point in needing to maintain both. However.. we could use a more compressed format of MultiAddress over protobuf messages and reconstruct to a multi-address for a smaller message payload. #1270
From discussions at the start of the year our RPC library is being deprecated in favor of using the Etherium Api endpoints and DFS api. What should we do with the current RPC projects. #1271
MessageDto is used heavily by dotnetty, this can probably be remove now as well as the channel context in observers. #1272
New LibP2P handlers should be added via AutoFac DI. #1273
Use the plain generic IPeerClient, IPeerService libraries for generic services instead of the one specific for libp2p.
What is the new behavior (if this is a feature change)?
LibP2P is used for the networking layer
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
closes Use libp2p in catalyst #1245 Add unit tests to custom Catalyst LibP2P protocol #1261 Allow node to discover nodes before the sync process starts. #1262 Increase sync download range message size limit. #1260 Use only connected peer nodes for sync progress. #1259 Fix issue with limitation on message size #1258 Add variant length to protobuf wire messages over custom Catalyst LibP2P protocol #1257 Use DFS Peer Discovery in Catalyst #1247 Convert to TCP from UDP #909 Current LibP2P implementation doesn't support message from one peer to another, only swam messaging. #1250 Use MultiFormat's multi address in places instead of IP/Port/PublicKey #1249 Create new pipeline handlers for PubSub messages. #1251 Connect PeerRepository to DFS for the population of new nodes and retrieval of seed nodes. #1248 As DFS service I want to use catalyst peer discovery DB #1144