Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner profiler update #1348

Merged
merged 29 commits into from
Nov 23, 2021
Merged

Runner profiler update #1348

merged 29 commits into from
Nov 23, 2021

Conversation

asteyo
Copy link
Contributor

@asteyo asteyo commented Nov 6, 2021

Pull Request FAQ

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest and minimal requirements?
  • Have you checked XLA integration with single and multiple processes?

@mergify
Copy link

mergify bot commented Nov 8, 2021

This pull request is now in conflicts. @asteyo, could you fix it? 🙏

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Scitator
Scitator reviewed Nov 11, 2021
View reviewed changes
catalyst/runners/runner.py Outdated
@@ -307,7 +307,19 @@ def get_callbacks(self, stage: str) -> "OrderedDict[str, Callback]":
callbacks["_overfit"] = BatchOverfitCallback()
if self._profile and not is_callback_exists(ProfilerCallback):
callbacks["_profile"] = ProfilerCallback(
tensorboard_path=os.path.join(self._logdir, "tb_profile")
tensorboard_path=os.path.join(self._logdir, "tb_profile"),
loader_key="train",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
loader_key="train",
epoch=1,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epoch=1 default in profiler init

@pep8speaks
Copy link

pep8speaks commented Nov 22, 2021 •
edited
Loading

Hello @asteyo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-11-22 19:32:12 UTC

@asteyo
Copy link
Contributor Author

asteyo commented Nov 22, 2021

Colab example: https://colab.research.google.com/drive/1G1Wipftfae8arvnOVkxBHSmrHahLFMFM?usp=sharing#scrollTo=N8XJ067t4-5z

@Scitator Scitator merged commit a5c6ce6 into catalyst-team:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scitator Scitator Scitator approved these changes

@bagxi bagxi Awaiting requested review from bagxi bagxi is a code owner

@ditwoo ditwoo Awaiting requested review from ditwoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asteyo @CLAassistant @pep8speaks @Scitator