Returned resume support
#1349
Merged
Returned resume support
#1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssed from one stage to another)
Scitator
previously approved these changes
Nov 8, 2021
Comment on lines
162
to
164
| def to_check_devices(): | ||
| cuda_devices = [f"cuda:{i}" for i in range(NUM_CUDA_DEVICES)] | ||
| return ["cpu", *cuda_devices] |
There was a problem hiding this comment.
🤔 should we simplify to cpu and cuda only? if it works on one GPU, we suppose, that it will work on the another too ;)
There was a problem hiding this comment.
i reformatted old test, but sure, we can simplify it
|
|
mergify
bot
dismissed
Scitator’s stale review
Pull request has been modified.
|
This pull request is now in conflicts. @y-ksenia, could you fix it? 🙏 |
Scitator
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request FAQ
Description
Returned
resumeto CheckpointCallback; added it's suppert to Runner.train and Runner.predict_loader; updated cli withresumeandautoresume.In addition changed behaviour of runner.model between stages (now model passes from one stage to another).
Related Issue
#1193
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Checklist
latestandminimalrequirements?