Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #854 EarlyStoppingCallback considers first epoch as bad #855

Merged
merged 5 commits into from
Jun 25, 2020

Conversation

alyaxey
Copy link
Contributor

@alyaxey alyaxey commented Jun 24, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • You can use 'Login as guest' to see Teamcity build logs.

Description

Fixed EarlyStoppingCallback considers first epoch as bad #854

Related Issue

EarlyStoppingCallback considers first epoch as bad #854

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@Scitator
Copy link
Member

Hi,
Thanks for issue-PR speedrun, really nice to see the progress of framework adoption :)

@Scitator Scitator merged commit 317c71f into catalyst-team:master Jun 25, 2020
@Scitator Scitator mentioned this pull request Jun 25, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EarlyStoppingCallback considers first epoch as bad
2 participants