Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add token expiry check #635

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Add token expiry check #635

merged 4 commits into from
Sep 17, 2024

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Sep 17, 2024 •
edited
Loading

Changes

  • Exposes a new method for clients to implement get_token_expiry_time, implemented only for Azure client atm
  • This is read by a check class and outputs OK, WARNING, ERROR based on the time of the expiry.
  • Fixup codestandards / pass ci

Testing

  • Covered by unit tests

Cherry picks

@matthewhilton matthewhilton mentioned this pull request Sep 17, 2024
Merged
@Peterburnett Peterburnett merged commit 3d2ce66 into MOODLE_310_STABLE Sep 17, 2024
18 checks passed
@Peterburnett Peterburnett deleted the add-token-expiry-check branch September 17, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewhilton @Peterburnett