updated python-versions and os-versions to use a default var

catalystneuro · Oct 22, 2024 · eefe6db · eefe6db
1 parent 6a8bc86
commit eefe6db
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 35 deletions.
diff --git a/.github/workflows/dailies.yml b/.github/workflows/dailies.yml
@@ -19,9 +19,6 @@ jobs:
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
       S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-    with:
-      python-versions: '["3.9", "3.10", "3.11", "3.12"]'
-      os-versions: '["ubuntu-latest", "macos-latest", "macos-13", "windows-latest"]'
 
   run-daily-dev-tests:
     uses: ./.github/workflows/dev-testing.yml
@@ -30,16 +27,11 @@ jobs:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
       AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
       S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
-    with:
-      python-versions: '["3.9", "3.10", "3.11", "3.12"]'
 
   run-daily-live-service-testing:
     uses: ./.github/workflows/live-service-testing.yml
     secrets:
       DANDI_API_KEY: ${{ secrets.DANDI_API_KEY }}
-    with:
-      python-versions: '["3.9", "3.10", "3.11", "3.12"]'
-      os-versions: '["ubuntu-latest", "macos-latest", "macos-13", "windows-latest"]'
 
   run-daily-neuroconv-docker-testing:
     uses: ./.github/workflows/neuroconv_docker_testing.yml

diff --git a/.github/workflows/deploy-tests.yml b/.github/workflows/deploy-tests.yml
@@ -40,17 +40,17 @@ jobs:
       S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
     with:  #  Ternary operator: condition && value_if_true || value_if_false
-      python-versions: ${{ github.event.pull_request.draft == true && '["3.9"]' || '["3.9", "3.10", "3.11", "3.12"]' }}
-      os-versions: ${{ github.event.pull_request.draft == true && '["ubuntu-latest"]' || '["ubuntu-latest", "macos-latest", "macos-13", "windows-latest"]' }}
+      python-versions: ${{ github.event.pull_request.draft == true && '["3.9"]' || '' }}
+      os-versions: ${{ github.event.pull_request.draft == true && '["ubuntu-latest"]' || '' }}
 
   # If the conversion gallery is the only thing that changed, run doctests only
   run-doctests-only:
     needs: assess-file-changes
     if: ${{ needs.assess-file-changes.outputs.CONVERSION_GALLERY_CHANGED == 'true' && needs.assess-file-changes.outputs.SOURCE_CHANGED != 'true' }}
     uses: ./.github/workflows/doctests.yml
     with:  #  Ternary operator: condition && value_if_true || value_if_false
-      python-versions: ${{ github.event.pull_request.draft == true && '["3.9"]' || '["3.9", "3.10", "3.11", "3.12"]' }}
-      os-versions: ${{ github.event.pull_request.draft == true && '["ubuntu-latest"]' || '["ubuntu-latest", "macos-latest", "macos-13", "windows-latest"]' }}
+      python-versions: ${{ github.event.pull_request.draft == true && '["3.9"]' || '' }}
+      os-versions: ${{ github.event.pull_request.draft == true && '["ubuntu-latest"]' || '' }}
 
 
   run-live-service-tests:
@@ -60,8 +60,8 @@ jobs:
     secrets:
       DANDI_API_KEY: ${{ secrets.DANDI_API_KEY }}
     with:  #  Ternary operator: condition && value_if_true || value_if_false
-      python-versions: ${{ github.event.pull_request.draft == true && '["3.9"]' || '["3.9", "3.10", "3.11", "3.12"]' }}
-      os-versions: ${{ github.event.pull_request.draft == true && '["ubuntu-latest"]' || '["ubuntu-latest", "macos-latest", "macos-13", "windows-latest"]' }}
+      python-versions: ${{ github.event.pull_request.draft == true && '["3.9"]' || '' }}
+      os-versions: ${{ github.event.pull_request.draft == true && '["ubuntu-latest"]' || '' }}
 
 
   check-final-status:

diff --git a/.github/workflows/dev-testing.yml b/.github/workflows/dev-testing.yml
@@ -5,9 +5,9 @@ on:
     inputs:
       python-versions:
         description: 'List of Python versions to use in matrix, as JSON string'
-        required: true
+        required: false
         type: string
-        default: '["3.9", "3.10", "3.11", "3.12"]'
+        default: ${{ vars.ALL_PYTHON_VERSIONS }}
     secrets:
       DANDI_API_KEY:
         required: true
@@ -28,7 +28,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ${{ fromJson(inputs.python-versions) }}
+        python-version: ${{ fromJson(!inputs.python-versions && vars.ALL_PYTHON_VERSIONS || inputs.python-versions) }}
     steps:
       - uses: actions/checkout@v4
       - run: git fetch --prune --unshallow --tags

diff --git a/.github/workflows/doctests.yml b/.github/workflows/doctests.yml
@@ -4,14 +4,14 @@ on:
     inputs:
       python-versions:
         description: 'List of Python versions to use in matrix, as JSON string'
-        required: true
+        required: false
         type: string
-        default: '["3.9", "3.10", "3.11", "3.12"]'
+        default: ${{ vars.ALL_PYTHON_VERSIONS }}
       os-versions:
         description: 'List of OS versions to use in matrix, as JSON string'
-        required: true
+        required: false
         type: string
-        default: '["ubuntu-latest", "macos-latest", "windows-latest"]'
+        default: ${{ vars.ALL_OS_VERSIONS }}
 
 
 jobs:
@@ -21,8 +21,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ${{ fromJson(inputs.python-versions) }}
-        os: ${{ fromJson(inputs.os-versions) }}
+        python-version: ${{ fromJson(!inputs.python-versions && vars.ALL_PYTHON_VERSIONS || inputs.python-versions) }}
+        os: ${{ fromJson(!inputs.os-versions && vars.ALL_OS_VERSIONS || inputs.os-versions) }}
     steps:
       - uses: actions/checkout@v4
       - run: git fetch --prune --unshallow --tags

diff --git a/.github/workflows/live-service-testing.yml b/.github/workflows/live-service-testing.yml
@@ -5,14 +5,14 @@ on:
     inputs:
       python-versions:
         description: 'List of Python versions to use in matrix, as JSON string'
-        required: true
+        required: false
         type: string
-        default: '["3.9", "3.10", "3.11", "3.12"]'
+        default: ${{ vars.ALL_PYTHON_VERSIONS }}
       os-versions:
         description: 'List of OS versions to use in matrix, as JSON string'
-        required: true
+        required: false
         type: string
-        default: '["ubuntu-latest", "macos-latest", "windows-latest"]'
+        default: ${{ vars.ALL_OS_VERSIONS }}
 
     secrets:
       DANDI_API_KEY:
@@ -28,8 +28,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ${{ fromJson(inputs.python-versions) }}
-        os: ${{ fromJson(inputs.os-versions) }}
+        python-version: ${{ fromJson(!inputs.python-versions && vars.ALL_PYTHON_VERSIONS || inputs.python-versions) }}
+        os: ${{ fromJson(!inputs.os-versions && vars.ALL_OS_VERSIONS || inputs.os-versions) }}
     steps:
       - uses: actions/checkout@v4
       - run: git fetch --prune --unshallow --tags

diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
@@ -5,14 +5,14 @@ on:
     inputs:
       python-versions:
         description: 'List of Python versions to use in matrix, as JSON string'
-        required: true
+        required: false
         type: string
-        default: '["3.9", "3.10", "3.11", "3.12"]'
+        default: ${{ vars.ALL_PYTHON_VERSIONS }}
       os-versions:
         description: 'List of OS versions to use in matrix, as JSON string'
-        required: true
+        required: false
         type: string
-        default: '["ubuntu-latest", "macos-latest", "windows-latest"]'
+        default: ${{ vars.ALL_OS_VERSIONS }}
 
 
     secrets:
@@ -33,8 +33,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ${{ fromJson(inputs.python-versions) }}
-        os: ${{ fromJson(inputs.os-versions) }}
+        python-version: ${{ fromJson(!inputs.python-versions && vars.ALL_PYTHON_VERSIONS || inputs.python-versions) }}
+        os: ${{ fromJson(!inputs.os-versions && vars.ALL_OS_VERSIONS || inputs.os-versions) }}
     steps:
       - uses: actions/checkout@v4
       - run: git fetch --prune --unshallow --tags