-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
one test fails for 2.5.1 release building with gcc 11/10 on i686-linux #2796
Comments
Looks like I underestimated how many people still build 32 bit packages without SSE2 for floats. Those tests will fail when compiled for the old x86 fpu. |
Thanks for the info on the core reason. This was found on Guix as we don't usually enable any extra architecture features by default. So at least for Guix I've enabled SSE2 so things build/test on i686 (see https://issues.guix.gnu.org/68429). |
Reported upstream to <catchorg/Catch2#2796>. It is expected that SSE2 is enabled for i686 builds or tests fail. * gnu/packages/check.scm (check2)[arguments]: Enable SSE2 for x86_64-linux and i686-linux in configure-flags. Co-authored-by: Richard Sent <richard@freakingpenguin.com> Co-authored-by: Jo Gay <@jane.lx.gay> Change-Id: I99205f92b66ab3d10affbfb58918f37069ba82ec
Thanks for the explanation!, Feel free to close this for my part |
Without SSE2 enabled, x86 targets will use x87 FPU, which breaks the tests checking for reproducible results from our random floating point number generators. The output is still reproducible, at least between binaries targetting x87, but the tests hardcode results for the whole pipeline being done in 32/64bit precision. Closes #2796
Describe the bug
The
REQUIRE_THAT( generated, Catch::Matchers::RangeEquals( uniform_fp_test_params<TestType>::expected ) )
test fails when building with gcc on i686-linux. (for type float?)Expected behavior
The test should pass as long as a supported compiler is used. (It does pass when building with clang++-10)
Reproduction steps
Build either with gcc 11.3 or gcc 10 targeting i686-linux.
Flags used:
Platform information:
Additional context
See https://gitlab.com/nonguix/nonguix/-/issues/307 for downstream discovery and discussion.
The text was updated successfully, but these errors were encountered: