captures with unexpected exceptions

[dvirtz]

Is it possible to make CAPTURE print its value when an unexpected exception occurs?
Currently, for the following code

#define CATCH_CONFIG_MAIN
#include <catch.hpp>
#include <stdexcept>

void foo()
{
    throw std::logic_error("error");
}

TEST_CASE("test")
{
    int i = 2;
    CAPTURE(i);
    foo();
    REQUIRE(false);
}

I get

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Test.exe is a Catch v1.1 b3 host application.
Run with -? for options

-------------------------------------------------------------------------------
test
-------------------------------------------------------------------------------
\giant_nas\dviry\my documents\visual studio 2015\projects\test\test\source.cpp(1
0)
...............................................................................

\giant_nas\dviry\my documents\visual studio 2015\projects\test\test\source.cpp(1
0): FAILED:
due to unexpected exception with message:
  error

===============================================================================
test cases: 1 | 1 failed
assertions: 1 | 1 failed

Press any key to continue . . .

While without calling foo() it's

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Test.exe is a Catch v1.1 b3 host application.
Run with -? for options

-------------------------------------------------------------------------------
test
-------------------------------------------------------------------------------
\giant_nas\dviry\my documents\visual studio 2015\projects\test\test\source.cpp(1
0)
...............................................................................

\giant_nas\dviry\my documents\visual studio 2015\projects\test\test\source.cpp(1
5): FAILED:
  REQUIRE( false )
with message:
  i := 2

===============================================================================
test cases: 1 | 1 failed
assertions: 1 | 1 failed

Press any key to continue . . .

[lightmare]

No it's not possible, because captures are local to the scope they appear in. When an unCHECKed exception occurs, that scope is finished (local objects holding CAPTURE destroyed) before entering the handler (the one that prints "FAILED: due to unexpected exception").

[onqtam]

I think it could be possible with the use of C++17's std::uncaught_exceptions to do something when the local objects (the capture stuff) are destroyed during stack unwinding due to an exception...

or maybe just logging in globals in the destructor of the local capture stuff

[dvirtz]

I was beaten by this again so I thought to give it a go and made a PR

[dvirtz]

Great, thanks!

…

On 4 April 2017 at 12:27, Martin Hořeňovský ***@***.***> wrote: Closed #748 <#748> via #876 <#876>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#748 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHTojfwAH9NbjMoVDfHUoNlG2J_93Lhoks5rsgz_gaJpZM4K314F> .