Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the first linebreak of messages that aborts printing #1455 #1470

Closed
wants to merge 2 commits into from

Conversation

Danielmelody
Copy link

Description

To handle something like this

TEST_CASE( "INFO and WARN start with a linebreak", "[messages][.]" ) {
    INFO( "\nthis is a " << "message start with a linebreak" );
    WARN( "\nthis is a " << "warning start with a linebreak" );
}

GitHub Issues

#1455

@Danielmelody Danielmelody changed the title fix the first linebreak of messages that aborts printing #1455 Fix the first linebreak of messages that aborts printing #1455 Dec 8, 2018
@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #1470 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   80.38%   80.35%   -0.03%     
==========================================
  Files         121      121              
  Lines        3425     3425              
==========================================
- Hits         2753     2752       -1     
- Misses        672      673       +1

1 similar comment
@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #1470 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   80.38%   80.35%   -0.03%     
==========================================
  Files         121      121              
  Lines        3425     3425              
==========================================
- Hits         2753     2752       -1     
- Misses        672      673       +1

@horenmar
Copy link
Member

horenmar commented Dec 9, 2018

Thanks for the PR, but the fix should go through the TextFlow repository (as the error is in a code that is 3rd party to Catch).
@philsquared

@Danielmelody
Copy link
Author

All right I see that, but that's quite confusing, I didn't even notice there are 3rd party codes in catch2 until you remind me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants