Add UNSCOPED_INFO to prefix/disabled sections #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually fails to compile, which is good
Codecov Report
@@ Coverage Diff @@
## master #1611 +/- ##
=======================================
Coverage 80.82% 80.82%
=======================================
Files 121 121
Lines 3420 3420
=======================================
Hits 2764 2764
Misses 656 656 |
|
Thanks for the fix. Also if you are willing, the tests could definitely use some expanding. There is always a trade-off in the amount of work that goes into them and apparently the X02 tests were on the wrong side. |
|
Just so we are on the same page: should I merge this PR and wait for a new one, or leave this one open for the new tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
UNSCOPED_INFOfeature was only added for the default usage. This adds defines so that it works under#define CATCH_CONFIG_PREFIX_ALLand/or#define CATCH_CONFIG_DISABLE.The
X02-DisabledMacros.cppis pretty thin and doesn't test individual macros, so only theCATCH_-prefixed modification is accounted for in tests. Expanding that test seemed out scope for this PR, but I'm happy to be the first if that's useful.GitHub Issues
Amends #1522, which introduced
UNSCOPED_INFO