Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android implementation of writeToDebugConsole that prints to Logcat #1710

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Add Android implementation of writeToDebugConsole that prints to Logcat #1710

merged 2 commits into from
Jul 31, 2019

Conversation

michaelcowan
Copy link
Contributor

Description

Adds an implementation of writeToDebugConsole for Android that logs directly to Logcat.

In my opinion, this provides a really good out-of-the-box experience for Android NDK developers.

Notes

I refrained from adding CATCH_PLATFORM_ANDROID and a catch_android_h_proxy.h as this felt a little heavy considering that the platform is really more Linux-like and the change is very focused. Happy to make any changes suggested though 😄

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #1710 into master will decrease coverage by 2.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1710      +/-   ##
==========================================
- Coverage   86.18%   83.93%   -2.25%     
==========================================
  Files         136      123      -13     
  Lines        5180     3398    -1782     
==========================================
- Hits         4464     2852    -1612     
+ Misses        716      546     -170

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #1710 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1710   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files         136      136           
  Lines        5180     5180           
=======================================
  Hits         4464     4464           
  Misses        716      716

@michaelcowan
Copy link
Contributor Author

The Travis job failed because of the Python configuration job which I think looks to be unrelated to this change.

The coverage decrease is annoying though. Not really sure how I can improve that without adding an Android test configuration.

@horenmar
Copy link
Member

If you rebase onto master, travis should work now. As for AppVeyor, you should use elif defined(CATCH_PLATFORM_WINDOWS), because it does not have integral value.

@horenmar horenmar merged commit e5c0e33 into catchorg:master Jul 31, 2019
@horenmar horenmar added the Tweak label Jul 31, 2019
@horenmar
Copy link
Member

Okay, thanks.

@michaelcowan michaelcowan deleted the android-logging branch July 31, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants