static constexpr: storage class first #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen with PGI compiler for `static constexpr`: ``` warning: storage class is not first ```
Codecov Report
@@ Coverage Diff @@
## master #1717 +/- ##
=======================================
Coverage 86.46% 86.46%
=======================================
Files 136 136
Lines 5273 5273
=======================================
Hits 4559 4559
Misses 714 714 |
|
Sure, why not. |
|
Thanks for merging, it's also the only location where the order was that way. |
horenmar
pushed a commit
that referenced
this pull request
Sep 21, 2022
This pull request fixes the warning issued by `nvc++` (the C++ compiler in Nvidia HPC SDK/PGI), and is similar to pull request #1717.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seen with PGI compiler for
static constexpr:GitHub Issues
N/A