Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use non-copyable and non-movable types in TEMPLATE_LIST_TEST_CASE #1729

Merged

Conversation

BenjaminW3
Copy link
Contributor

This is a follow-up to #1697.

The parameter given to convert may not be copyable therefore it has to be
captured by const reference. For example an std::tuple that contains a
non-copyable type is itself non-copyable.

The NonDefaultConstructible test-case was reduced by one example type
because it did not add any value.

…_CASE

The parameter given to `convert` may not be copyable therefore it has to be
captured by const reference. For example an `std::tuple` that contains a
non-copyable type is itself non-copyable.

The NonDefaultConstructible test-case was reduced by one example type
because it did not add any value.
@BenjaminW3
Copy link
Contributor Author

Independent from my changes CI seems to be broken:

0.78s$ sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install clang-6.0 libstdc++-8-dev
Reading package lists...
Building dependency tree...
Reading state information...
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
 clang-6.0 : Depends: libjsoncpp0 (>= 0.6.0~rc2) but it is not installable
E: Unable to correct problems, you have held broken packages.
apt-get.diagnostics
apt-get install failed
The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install clang-6.0 libstdc++-8-dev" failed and exited with 100 during .
Your build has been stopped.

@horenmar
Copy link
Member

horenmar commented Sep 6, 2019

Thanks, the CI should be fixed soon(ish) and I'll merge this afterwards.

@horenmar horenmar added the BugFix label Sep 6, 2019
@horenmar horenmar merged commit 18d597c into catchorg:master Sep 6, 2019
@BenjaminW3 BenjaminW3 deleted the topic-fix-non-copyable-type-lists branch September 6, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants