Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch:Failure to pass special chars through input file #1769

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

amitherman95
Copy link
Contributor

Description

When Catch parses quoted test name, it may insert wrong positions of escape characters into
TestSpecParser::m_escapeChars, because the quotes are not added to the pattern itself
I added a simple data member to TestSpecParser that will track the right location of those characters in the pattern.

GitHub Issues

This PR resolves Issue #1767

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #1769 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1769     +/-   ##
=========================================
+ Coverage   87.61%   87.81%   +0.2%     
=========================================
  Files         137      137             
  Lines        5406     5413      +7     
=========================================
+ Hits         4736     4753     +17     
+ Misses        670      660     -10

@horenmar horenmar added the BugFix label Oct 9, 2019
@horenmar
Copy link
Member

horenmar commented Oct 9, 2019

Thanks, I fixed up the branch history and added tests for the changes.

@horenmar horenmar merged commit 1c57496 into catchorg:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants