include <iterator> in catch_stats.hpp #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed for std::back_inserter on some platforms
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
=======================================
Coverage 86.48% 86.48%
=======================================
Files 131 131
Lines 3898 3899 +1
=======================================
+ Hits 3371 3372 +1
Misses 527 527 |
|
Interesting, I changed the v3 branch to always build benchmarking tests and I do not remember having to fix this. Either way, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for
std::back_inserteron some platforms (in particular, windows) when buildingcatch_stats.cpp.