Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1992: Better c++17 std::byte detection #1996

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

gnbond
Copy link
Contributor

@gnbond gnbond commented Aug 3, 2020

This fixed buld errors for ubuntu-16 + clang and similar situations
where C++17 is supported in the compiler but not the default
C++ standard library.

Description

Clang packages on ubuntu-16 use the clang compiler which supports C++17, but use the system-default C++ library which does not fully support C++17. This results in compile errors where Catch2 mis-identifies support for std::bytes.

GitHub Issues

Closes #1992

This fixed buld errors for ubuntu-16 + clang and similar situations
where C++17 is supported in the compiler but not the default
C++ standard library.
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1996 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1996   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files         138      138           
  Lines        5651     5651           
=======================================
  Hits         5015     5015           
  Misses        636      636           

@horenmar horenmar added the BugFix label Aug 3, 2020
@horenmar
Copy link
Member

horenmar commented Aug 3, 2020

Thanks

@horenmar horenmar merged commit 708487d into catchorg:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++17 std::byte detection fails on ubuntu+clang-6.0
2 participants