fix compilation on cygwin #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimztimz
suggested changes
Oct 3, 2022
Use std::char_traits<char>::find instead of strnlen for better portability.
Codecov Report
@@ Coverage Diff @@
## devel #2540 +/- ##
==========================================
+ Coverage 91.56% 91.58% +0.02%
==========================================
Files 183 183
Lines 7558 7564 +6
==========================================
+ Hits 6920 6927 +7
+ Misses 638 637 -1 |
|
The build errors on mac don't look like they have anything to do with this PR. Looks more like a gcc problem on MacOS. |
|
Yep, the Mac issue seems to be a known issue with new toolchain, and I guess the MacOS image got recently updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use std::char_traits::find instead of strnlen for better portability.
GitHub Issues