Make ScopedMessage in INFO logging macro const #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If users have const correctness checks enabled then this would flagged forcing users to wrap the INFO macro themselves or forego using it altogether.
Codecov Report
@@ Coverage Diff @@
## devel #2564 +/- ##
==========================================
- Coverage 91.09% 91.09% -0.00%
==========================================
Files 187 187
Lines 7623 7622 -1
==========================================
- Hits 6944 6943 -1
Misses 679 679 |
|
Sure, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What: Made Catch::ScopedMessage in the INFO logging macro const because it is not modified.
Why: If users have const correctness checks enabled then the current non-const message would be flagged forcing users to wrap the INFO macro themselves or forego using it altogether.
We encountered this while using clang-tidy with the
misc-const-correctnesscheck.GitHub Issues