Export symbols for all compilers on Windows #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #2630 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 187 187
Lines 7691 7691
=======================================
Hits 7010 7010
Misses 681 681 |
|
Thanks.
After reading the docs, I agree. But since the conditional still has to be there (the behaviour of static libraries compiled with default visibility and hidden visibility is different when they are linked into dynamic library later), I think it is fine to leave it the way it is now. |
horenmar
added
the
Building and Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linking Catch2 v3.2.1 as a shared library when using Clang on Windows fails because symbols only get exported for MSVC (and MSVC-like compilers) but not for Clang. Removing this conditional means that Clang on Windows now gets this too. This should have no effect on compilers on non-Windows platforms. I believe we could move this out of the
if(BUILD_SHARED_LIBS)block as well since it will just do nothing if you're building static libraries.Here are two CI pipeline runs from SFML illustrating before and after applying this patch.
Before:
https://github.com/ChrisThrasher/SFML/actions/runs/3946193148
After
https://github.com/ChrisThrasher/SFML/actions/runs/3972002714