reporters: silence -Wsubobject-linkage

[timblechmann]

gcc emits Wsubobject-linkage, because the the publicly visible TablePrinter contains ColumnInfo, which is part of an anonymous namespace

Description

path/to/src/catch2/reporters/catch_reporter_console.cpp:296:7: warning: ‘Catch::TablePrinter’ has a field ‘Catch::TablePrinter::m_columnInfos’ whose type uses the anonymous namespace [-Wsubobject-linkage]
  296 | class TablePrinter {
      |       ^~~~~~~~~~~~

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (863c662) 91.37% compared to head (952d094) 91.37%.

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #2794   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         198      198           
  Lines        8297     8297           
=======================================
  Hits         7581     7581           
  Misses        716      716           

[horenmar]

What GCC versions do you see this with? I tried adding the flag locally and 11.4.0 does not warn about the current code.

[timblechmann]

i'm seeing this with gcc-13 (i could assume that unity builds / lto may also affect this warning being emitted).

as a rule of thumb a struct that's not in an anonymous namespace should not contain any members that are defined in an anonymous namespace