-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Conan recipe support #2831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries
commented
Mar 4, 2024
uilianries
commented
Mar 4, 2024
uilianries
commented
Mar 4, 2024
uilianries
commented
Mar 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2831 +/- ##
==========================================
+ Coverage 91.16% 91.19% +0.03%
==========================================
Files 197 197
Lines 8381 8379 -2
==========================================
+ Hits 7640 7641 +1
+ Misses 741 738 -3 |
horenmar
added
the
Building and Packaging
Issues affecting build/packaging scripts and utilities
label
Mar 12, 2024
horenmar
reviewed
Mar 12, 2024
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello! This PR brings a better compatibility and usability with Conan 2.x for the recipe maintained in this repository. Here is some information to understand these changes:
BUILD_SHARED_LIBS
andPOSITION_INDEPENDENT_CODE
to CMake commandGitHub Issues
No related issues.
Build log
/cc @rubenRBS