conanfile: fix cmake_target_name of Catch2::Catch2. #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Catch2 without default main" target is currently unspecified in Conan, and defaults to catch2::catch2base. This commit switches it back to Catch2::Catch2, as specified in the docs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2861 +/- ##
==========================================
+ Coverage 91.09% 91.10% +0.01%
==========================================
Files 197 197
Lines 8382 8382
==========================================
+ Hits 7635 7636 +1
+ Misses 747 746 -1 |
horenmar
added
the
Building and Packaging
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Catch2 without default main" target doesn't have a specific name in Conan, and defaults to catch2::catch2base. This commit switches it back to Catch2::Catch2, as described in the docs.