Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-tidy bugprone-chained-comparison warnings on v2.x #2862

Merged

Conversation

rikyoz
Copy link

@rikyoz rikyoz commented Apr 23, 2024

This PR is just a backport of the #2801 PR on the v2.x branch.
It suppresses the bugprone-chained-comparison warning issued by recent versions of clang-tidy.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (a7782d1) to head (a2b2e1f).

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.x    #2862   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files         113      113           
  Lines        5040     5040           
=======================================
  Hits         4540     4540           
  Misses        500      500           

@horenmar horenmar merged commit ee1450f into catchorg:v2.x Apr 25, 2024
3 checks passed
@horenmar
Copy link
Member

Out of curiosity, why are you still using v2?

@rikyoz
Copy link
Author

rikyoz commented Apr 25, 2024

Thank you for the merge!

Out of curiosity, why are you still using v2?

Mainly because I still need to support old compilers like GCC 4.9 or MSVC 2015 in some of the projects where I use Catch2.
In one of these projects, I actually upgraded to v3 at some point, but then had to go back to v2 for this reason.
I'll definitely upgrade to v3 as soon as I can raise the minimum requirements for them.

@rikyoz rikyoz deleted the backport-clang-tidy-bugprone-chained-comparison branch April 26, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants