Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of unused parameter in TestEventListenerBase::assertionEnded() #530

Closed
wants to merge 1 commit into from

Conversation

vadz
Copy link
Contributor

@vadz vadz commented Oct 28, 2015

Just don't name this parameter to avoid warnings about it being unused.

No real changes.

Just don't name this parameter to avoid warnings about it being unused.

No real changes.
@nabijaczleweli
Copy link
Contributor

👍

@michaelbprice
Copy link

Nice and simple. 👍

@philsquared
Copy link
Collaborator

Thanks for catching that.
I couldn't merge the PR as it conflicts with the single_include header (in general please don't update the header in single_include as it is generated by splicing all the other headers together).
So I've just reapplied the same fix - will make it in to the develop branch soon,.

@philsquared philsquared closed this Nov 4, 2015
philsquared added a commit that referenced this pull request Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants