Improve stability of benchmark-based CPU throttle scaling #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmeenan any reason for which this is closed? was not working as expected? |
|
It's working as expected and we have deployed it in the HTTP Archive. I've had a few PR's that weren't getting any traction so I assumed it was no longer being actively maintained. If that's not the case, I'm happy to restore it and reopen the PR. |
This was referenced Feb 28, 2024
Closed
claud-io
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts a limit on the maximum scale that will be applied to CPU throttling (defaults to 2) as well as records the benchmark results for the last 9 benchmarks (9 hours of agent running usually) and picks the median result so that benchmark outliers don't skew the CPU throttling.