Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check node up #103

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix: check node up #103

merged 1 commit into from
Feb 2, 2024

Conversation

kidneyweakx
Copy link
Contributor

@kidneyweakx kidneyweakx commented Feb 2, 2024

PULL REQUEST

Before

說明 (Description)

  • fix channel create and orderer nslookup error in unit test
  • my stupid fault in test/fabric/service/caService.test.ts just move the place

相關問題 (Linked Issues)

  • update 2.1.0 github action error

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS: 14.2.1
  • NodeJS Version: 9.8.1
  • NPM Version: 18.18.2
  • Docker Version: 24.0.6

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單,並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)

@kidneyweakx kidneyweakx changed the base branch from 2.1.0 to master February 2, 2024 05:20
@kidneyweakx kidneyweakx marked this pull request as draft February 2, 2024 06:40
@kidneyweakx kidneyweakx changed the base branch from master to 2.1.0 February 2, 2024 07:55
@kidneyweakx kidneyweakx marked this pull request as ready for review February 2, 2024 08:12
@kth-tw kth-tw merged commit b4e3039 into 2.1.0 Feb 2, 2024
6 checks passed
@kth-tw kth-tw deleted the fix/checkNodeUp branch February 2, 2024 08:17
Pianochicken added a commit that referenced this pull request Feb 2, 2024
* refactor: replace all then to promise (#96)

* feat: bootnode mode (#97)

* feat: bootnode mode

* feat: assign specified node to be bootnode

* fix: remove console log

* fix: eslink and test

* fix: adjust for pr comments

* feat: optimize create network process (#100)

* feat:  transform bdk ui to quorum dashboard (#99)

* feat: bdk ui dashboard

* fix: modify reviewed code

* fix(ui): network info json location

---------

Co-authored-by: kidneyweak <kidneyweak@gmail.com>

* fix: modify ui to dashboard (#101)

* update: 2.1.0 bdk dashboard

* fix(ca): promise catch test error (#103)

---------

Co-authored-by: Chengwei-Lin <39145342+LinXJ1204@users.noreply.github.com>
Co-authored-by: JakeKuo <jake0627a1@gmail.com>
Co-authored-by: PianoChicken <pianochicken1996@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants