Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/besu network update #109

Closed
wants to merge 10 commits into from
Closed

Conversation

a7351220
Copy link

PULL REQUEST

Before

說明 (Description)

相關問題 (Linked Issues)

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS:
  • NodeJS Version:
  • NPM Version:
  • Docker Version:

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單,並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)

@kidneyweakx
Copy link
Contributor

@johnny30678 you should review this PR.
Wrong lint, empty git commit user, and all failed CI.

@kidneyweakx kidneyweakx reopened this Aug 21, 2024
@kidneyweakx kidneyweakx mentioned this pull request Aug 21, 2024
14 tasks
@kidneyweakx kidneyweakx changed the base branch from master to 3.1.0 August 21, 2024 07:36
@kidneyweakx
Copy link
Contributor

I think you should seperate make the improvement

  1. move all files from quorum to eth, or I think evm should much better
  2. update the besu network config
  3. update the kubernetes part

Now it's hard to review and try to find the issues

@a7351220 a7351220 closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants