Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover #48

Merged
merged 7 commits into from
Jan 17, 2022
Merged

Discover #48

merged 7 commits into from
Jan 17, 2022

Conversation

kth-tw
Copy link
Collaborator

@kth-tw kth-tw commented Jan 10, 2022

PULL REQUEST

說明 (Description)

  1. chaincode deploy/commit/invoke/query 無需再選 endorsers 的節點
  2. 不需要其他peer的tlsca(channel create/join時仍需要orderer的)
  3. 移除 memory-stream 套件,使用內建的 stream.Writable (因為stdout太長,用memory-stream會被切斷)

相關問題 (Linked Issues)

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS:
  • NodeJS Version:
  • NPM Version:
  • Docker Version:

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單,並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)

@kth-tw kth-tw force-pushed the discover branch 7 times, most recently from 268d4ac to b333aed Compare January 14, 2022 09:44
@kth-tw kth-tw marked this pull request as ready for review January 17, 2022 01:10
@SecondDim SecondDim merged commit 8e620d7 into cathayddt:master Jan 17, 2022
@kth-tw kth-tw mentioned this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants