Package list caching in zsh autocompletion does not work

[pklip]

System Info

• Operating System: Linux abtz0gta 4.8.0-46-generic Feature request: Support for creating eclipse projects #49~16.04.1-Ubuntu SMP Fri Mar 31 14:51:03 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
• Python Version: Python 2.7.12
• Version of catkin_tools: catkin_tools 0.4.4
• ROS Distro: kinetic
• Shell: zsh

Issue

Autocompletion in zsh with _catkin does not actually use the caching mechanism to cache the package list, although the code intends to do so. Only the environment variable _workspace_packages is set once in the current shell and then never saved to the cache or updated anymore.

Expected Behavior

On autocompletion (TAB) the current package list should be saved to [catkin_workspace]/.catkin_tools/cache/workspace_packages and be retrieved on further completions if the workspace did not change and the variable _workspace_packages has not already been set

Actual Behavior

The cache is never used.

Steps to Reproduce the Issue

Copy completion/_catkin to /usr/local/share/zsh/site-functions (or anywhere in your $fpath) and make sure compinit is called in your .zshrc (preferrably at the very end after any plugins).

[timonegk]

The issue was fixed in #475.